Professional software engineer, musician, gamer, stoic, democratic socialist

  • 2 Posts
  • 85 Comments
Joined 3 years ago
cake
Cake day: July 2nd, 2023

help-circle


  • You are correct to point out the distinction between race conditions and data races. Rust only rules out data races.

    I don’t know whether the race in question was a data race or not.

    I would still wager that Rust code generally has fewer race conditions than C, given that mutable aliasing can be used as symbolic prevention of race conditions, i.e. your &mut T doesn’t necessarily need to hold data; it can represent some domain concept.

    aren’t language specific

    There are actually languages that guarantee deterministic concurrent execution, and this can rule out larger classes of race conditions than just data races. See the Bloom language and CALM theorem.









  • Competent developers make mistakes too. I think it’s worth at least skimming every line in a PR. Things like indexing out of bounds should probably be handled by testing or using a memory safe language.

    I don’t think code review is the place where you should be trying to catch bugs in the minutia of the code. You should be assessing readability/maintainability, architectural decisions, risk, and testing strategy. That does involve reading all of the code, even if only by skimming.